If you're playing a Warrior than most obviously you can really build it a Tanky DPS no matter what. In terms of damage you can go Condition damage with a One hand sword or you can go Critical Damage with a Greatsword. Both are very viable builds. I won't get into detail as to how efficient they will be in PvP though. As there are stronger damage builds that don't use a sword.
If you do Sword + Shield, then you really can do either conditional or critical. There is a trait that gives you +10% critical to swords. But a Sword in itself has some inherent bleed built into it, so you can also get full conditional armor as well.
There are a bunch of Sigils that proc really nicely from criticals. You might want to put a Sigil of Bloodlust on one hand and a Sigil of Strength on the other hand when you dual wield or consider using a Sigil of Earth to proc Bleed as you Crit.
And how "tanky" you want to be is up to you and always situational. You can always get different stat type armor from dungeons.
Personally, I built a hybrid damage and toughness armor build and for weapons, I use Dual Wield Swords, Sword + Shield, and Great sword and i have different stats and sigils on each weapon and I equip them depending on whether i'm doing general farming, dungeon speed runs, Fractals, WvW etc.
Edited by Stigma, 18 December 2012 - 03:54 AM.